Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

Fixing Flight Mode #803

Closed
wants to merge 2 commits into from
Closed

Fixing Flight Mode #803

wants to merge 2 commits into from

Conversation

Saurabh-001-S
Copy link
Contributor

Description

when we click on Flight mode then is not changing the wifi icon to flight icon and also not off the wifi.
So use useEffect to listen when click on Flight mode then first change state the sidepane reducer of airplaneMode(change ui to true or false or vice versa) then target the wifi element with action payload(wifiElement) and also get another attribute of wifiElement of data state(when we click on sidepane icons it change data - state to true), here we use that to when we click on flight mode then we change the wifiElement(data - state) to false and also chnage the icon of wifi to airplane mode using useState to chnage the icon src.

Type of change

Change in Taskbar index.js
Changes Reducer sidepane.js

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

@win11bot
Copy link
Collaborator

win11bot commented Oct 5, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@win11bot
Copy link
Collaborator

win11bot commented Oct 5, 2023

Deployed with 📄 GitHub Pages

Commit: 16e6803
Status: ✅ Success
Preview: https://pr-preview.win11react.com/803
Deploy Log: https://github.com/blueedgetechno/win11React/actions/runs/6419437451

@Saurabh-001-S
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

win11bot added a commit that referenced this pull request Oct 5, 2023
@Saurabh-001-S Saurabh-001-S closed this by deleting the head repository Oct 5, 2023
@git-init-priyanshu
Copy link
Contributor

@Saurabh-001-S why did you close this PR?

@Saurabh-001-S
Copy link
Contributor Author

I fix the flight mode @git-init-priyanshu

@git-init-priyanshu
Copy link
Contributor

I fix the flight mode @git-init-priyanshu

Which PR?

@Saurabh-001-S
Copy link
Contributor Author

commit in this

@git-init-priyanshu
Copy link
Contributor

commit in this

It appears there might be some confusion. To see your changes incorporated into the final build, a maintainer must merge your pull request (PR). The commit you have mentioned is by the bot, and not from your PR, i think.

@git-init-priyanshu
Copy link
Contributor

One more thing to note is that you should only raise a pull request (PR) when the issue has been assigned to you. It is considered a best practice to have the issue assigned to you before creating a PR. If the issue has not been assigned to you, you can choose to work on other issues instead. I hope this clarifies things.

@Saurabh-001-S
Copy link
Contributor Author

My mistake bro sorry for that

@git-init-priyanshu
Copy link
Contributor

My mistake bro sorry for that

No worries. It's a part of learning.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants